herbsjs / herbs2rest

Create a REST API based on HerbsJS

MIT License

2 stars 13 forks source link

feat(generateroutes.js): generate route param name dinamically #33

Closed mtperesvx closed 2 years ago

mtperesvx commented 2 years ago

feat(generateroutes.js): generate route param name dinamically with entity's id field name

In the file generated by running the Herbs CLI, we inserted a entity parameter to export entity informations that is highlighted on the image above.

codecov[bot] commented 2 years ago

Codecov Report

Merging #33 (ea44229) into main (2cfcda9) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #33   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          106       108    +2     
=========================================
+ Hits           106       108    +2

Impacted Files	Coverage Δ
src/generateRoutes.js	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2cfcda9...ea44229. Read the comment docs.

herbsjs-robot commented 2 years ago

:tada: This PR is included in version 3.0.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

jhomarolo commented 2 years ago

It seems this PR needs the update inside read.me and the herbs site.

@mtperesvx could you please open another PR with these changes please?

mtperesvx commented 2 years ago

@jhomarolo sure. The updates is in PR: https://github.com/herbsjs/herbs2rest/pull/34 https://github.com/herbsjs/herbsjs.github.io/pull/137

dalssoft commented 2 years ago

FYI - fix commit: https://github.com/herbsjs/herbs2rest/commit/19b3fce876b2621f4154dd85c4eee51ccc3b568a