herbsjs / herbs2rest

Create a REST API based on HerbsJS
MIT License
2 stars 13 forks source link

feat: application crashes when property entity is not passed #34

Closed mtperesvx closed 2 years ago

mtperesvx commented 2 years ago
codecov[bot] commented 2 years ago

Codecov Report

Merging #34 (ef1e566) into main (ea44229) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head ef1e566 differs from pull request most recent head 8f50987. Consider uploading reports for the commit 8f50987 to get more accurate results

@@            Coverage Diff            @@
##              main       #34   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          108       109    +1     
=========================================
+ Hits           108       109    +1     
Impacted Files Coverage Δ
src/generateRoutes.js 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jhomarolo commented 2 years ago

@mtperesvx could you please fix the conflict and improve the test scenario?

mtperesvx commented 2 years ago

@jhomarolo Sure, This branch was out of date. I opened another PR to upload the changes and closed this PR.

https://github.com/herbsjs/herbs2rest/pull/38