herbsjs / herbs2rest

Create a REST API based on HerbsJS

MIT License

2 stars 13 forks source link

feat(herbs2rest): using Herbarium to create REST endpoints #35

Closed Anderson-Costa-Vx closed 2 years ago

Anderson-Costa-Vx commented 2 years ago

22

Fixes #

Proposed Changes

Using Herbarium to create REST endpoints

Readiness Checklist

Author/Contributor

[ ] If documentation is needed for this change, has that been included in this pull request
[ ] Remember to check if code coverage decrease, if so, please implement the necessary tests

Reviewing Maintainer

[ ] Label as breaking if this is a large fundamental change
[ ] Label as either automation, bug, documentation, enhancement, infrastructure, or performance

codecov[bot] commented 2 years ago

Codecov Report

Merging #35 (a394c88) into main (ea44229) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head a394c88 differs from pull request most recent head 4c25b4d. Consider uploading reports for the commit 4c25b4d to get more accurate results

@@            Coverage Diff            @@
##              main       #35   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         6    +1     
  Lines          108       129   +21     
=========================================
+ Hits           108       129   +21

Impacted Files	Coverage Δ
src/generateControllers.js	`100.00% <100.00%> (ø)`
src/generateRoutes.js	`100.00% <100.00%> (ø)`
src/helpers/castRequest.js	`100.00% <100.00%> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jhomarolo commented 2 years ago

@dalssoft I think we have a different problem here with aloe, a kind of circular reference issue maybe.

The CI is breaking because the aloe is requesting buchu to work, but the herbs2rest does not need it. When buchu was added to dev dependencies, worked.

I think this PR is good to go if you are done, but we need to discuss this. Maybe by removing the aloe from herbs core or removing the peerdependency from aloe, the issue will be resolved.

jhomarolo commented 2 years ago

@Anderson-Costa-Vx your PR was approved, but we won't merge until we figure out the aloe dependency problem, ok?

Anderson-Costa-Vx commented 2 years ago

@Anderson-Costa-Vx your PR was approved, but we won't merge until we figure out the aloe dependency problem, ok?

Ok. Thanks.

dalssoft commented 2 years ago

The CI is breaking because the aloe is requesting buchu to work, but the herbs2rest does not need it.

I wasn't able to reproduce the problem. Do we still have a problem? How is it possible to reproduce?

Meanwhile, we could start the issue https://github.com/herbsjs/herbs-cli/issues/125, right?

jhomarolo commented 2 years ago

@dalssoft the problem is happening only inside the CI (there is should be a way to reproduce this) of Github and you need to remove buchu from dependencies

herbsjs-robot commented 2 years ago

:tada: This PR is included in version 3.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: