herbsjs / herbs2rest

Create a REST API based on HerbsJS

MIT License

2 stars 13 forks source link

fix: 🐛 fixing the findUsecases function #44

Closed Vx-Nico closed 2 years ago

Vx-Nico commented 2 years ago

Fixes #

Proposed Changes

Fix the findUsecases function to generate the "findAll" routes.

Readiness Checklist

Author/Contributor

[ ] If documentation is needed for this change, has that been included in this pull request
[ ] Remember to check if code coverage decrease, if so, please implement the necessary tests

Reviewing Maintainer

[ ] Label as breaking if this is a large fundamental change
[ ] Label as either automation, bug, documentation, enhancement, infrastructure, or performance

dalssoft commented 2 years ago

@Vx-Nico your code changes the src, but not the tests. where is the test case exercising this scenario you changed?

not sure, but the reason why the CI is not building might be because the test for this scenario is broken.

codecov[bot] commented 2 years ago

Codecov Report

Merging #44 (c072b53) into main (ace5876) will not change coverage. The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main       #44   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          131       133    +2     
=========================================
+ Hits           131       133    +2

Impacted Files	Coverage Δ
src/generateControllers.js	`100.00% <100.00%> (ø)`
src/generateRoutes.js	`100.00% <100.00%> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

herbsjs-robot commented 2 years ago

:tada: This PR is included in version 3.2.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: