perf(generateroutes): improved readability for getForcedPath and getVerb - Githubissues

herbsjs / herbs2rest

Create a REST API based on HerbsJS

MIT License

2 stars 13 forks source link

perf(generateroutes): improved readability for getForcedPath and getVerb #53

Closed vitorgamer58 closed 1 year ago

vitorgamer58 commented 1 year ago

Proposed Changes

Better code quality and readability

Readiness Checklist

Author/Contributor

[x] If documentation is needed for this change, has that been included in this pull request
[x] Remember to check if code coverage decrease, if so, please implement the necessary tests

Reviewing Maintainer

[ ] Label as breaking if this is a large fundamental change
[ ] Label as either automation, bug, documentation, enhancement, infrastructure, or performance

codecov[bot] commented 1 year ago

Codecov Report

Merging #53 (1d1774b) into main (7b58174) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head 1d1774b differs from pull request most recent head dbc87f1. Consider uploading reports for the commit dbc87f1 to get more accurate results

@@            Coverage Diff            @@
##              main       #53   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          188       169   -19     
=========================================
- Hits           188       169   -19

Impacted Files	Coverage Δ
src/generateRoutes.js	`100.00% <100.00%> (ø)`

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

herbsjs-robot commented 1 year ago

:tada: This PR is included in version 4.1.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: