added community contents

herbsjs / herbsjs.github.io

Herbs website and docs

https://herbsjs.org/

Other

11 stars 40 forks source link

added community contents #151

Closed italojs closed 1 year ago

italojs commented 1 year ago

Fixes https://github.com/herbsjs/herbsjs.github.io/issues/109

Proposed Changes

Created a page for linking the content created by the community

Screen Shot 2022-11-26 at 08 21 16

Reviewing Maintainer

[ ] Label as breaking if this is a large fundamental change
[ ] Label as either automation, bug, documentation, enhancement, infrastructure, or performance

italojs commented 1 year ago

@dalssoft @jhomarolo

jhomarolo commented 1 year ago

Make sense all contents labels be in English ?

italojs commented 1 year ago

i dont think so, because it could be a bad experience when the developer access this page, open a article and it be in another language.

what we could to do is add a language info. example:

language: en language: pt-br

dalssoft commented 1 year ago

Great PR. Thank you @italojs

Regarding the content, I agree with @jhomarolo . I think the content of the site should be all English. If the link takes to a non-engligh content, it should be indicated, as you suggested.

italojs commented 1 year ago

done

jhomarolo commented 1 year ago

Can you please send a print screen about the new version?

italojs commented 1 year ago

Screen Shot 2023-01-27 at 14 45 54

dalssoft commented 1 year ago

@italojs, PR approved. But we changed the policy to only accept signed commits. Could you singed it?

The base branch requires all commits to be signed

italojs commented 1 year ago

done @dalssoft

jhomarolo commented 1 year ago

@italojs I think the link is not working.

https://herbsjs.org/docs/project/communitycontent when I click in some news, nothing happens!