Closed dalssoft closed 2 years ago
Just to give some example about what we can explore, I would like to share this link that Dalsoft shared with me
we have many diagrams opportunity to explore with this feature
why did you reopen it? If you reopen it becase we need to improve the current implementation, you could to open another issue, becase the #41 PR already fix this current issue
becase the https://github.com/herbsjs/herbsshelf/pull/41 PR already fix this current issue
well, not really. the initial idea was to have this diagrams inside Shelf UI with diagrams auto generated by Herbs metadata. The PR above only allows to Mermaid diagrams to be part of the README file, created manually (which is completely fine).
@dalssoft is right. I reopened it because is not totally closed yet.
Hi guys! I will work on this issue!
Hey guys. Any suggestion? I'm working on this feature and just missing details to complete it.
@maikmb ideally we could have a more in-depth discussion on how to document the entities, but thinking about it, I believe your suggestion would work well for a first version
Thanks @dalssoft! We will implement the first version and improve it later.
Maik, I believe the diagram connection (1 ... N ) in the image is missing, right?
Like this:
Hi @jhomarolo! I was implementing this feature.
Looks great. We should test it in a big project and see how it behaves.
@maikvortx I think is missing the pointer showing the relation 1 ... N
Inside the diagram should be TodoList "1" --> "*" Item
But, anyhow, looks amazing! This is a huge feature
Hi everyone! @jhomarolo The relationship is created automatically by herbsshelf.
Hey guys, I have implemented the new version of the herbs shelf in internal project and I have an example of a complex entities class diagram:
@maikvortx, It's becoming excellent! I have only two considerations:
1 - About the ordering of the diagram. Is there any way to sort the diagram automatically? It seemed to me that the diagram gets a little confusing in a big system
Like this:
2 - I believe that mine needs to include use cases and entities. That is, create a folder called use cases and leave them there. From the way you sent the print, it implies that the entities link is also a use case
Does it make sense to you? I think we're almost there on this PR!
@maikmb amazing work! this is going to be a killer feature!
I agree with @jhomarolo on (1): i think we should find a way to implement a diagram reorder. ideally having a button where the user can choose which reorder they want. regarding (2) (to include use cases and entities), i think it is a improvement we can discuss, but for now I would leave without UCs.
Hey guys! I agree with you.
(1) What do think about implementing diagram reorder in another PR? I will study Mermaid to implement this feature. In a big project, the class diagram gets a little confusing. (2) About usecases, I will implement this in another PR for this issue #37
I will study Mermaid to implement this feature. In a big project, the class diagram gets a little confusing.
"de bate pronto", is there a any indication of Mermaid having this feature? It doesn't seem like it https://github.com/mermaid-js/mermaid/issues/806
I have an example of a complex entities class diagram https://github.com/herbsjs/herbsshelf/issues/38#issuecomment-1174549539
We could use groups metadata to entities like we have in use cases. This way we could create sub-views to view entities so we don´t have to show the whole thing... yes, I know, it is another issue, but just to document it
@maikmb It seems we have many ideas of improvements here. But what is missing to accept this PR? https://github.com/herbsjs/herbsshelf/pull/47
I have an example of a complex entities class diagram https://github.com/herbsjs/herbsshelf/issues/38#issuecomment-1174549539
We could use groups metadata to entities as we have in use cases. This way we could create sub-views to view entities so we don´t have to show the whole thing... yes, I know, it is another issue, but just to document it
It's a good idea @dalssoft. I can implement it in another PR.
@maikmb It seems we have many ideas for improvements here. But what is missing to accept this PR? https://github.com/herbsjs/herbsshelf/pull/47
@dalssoft I think this PR can be approved. The improvements discussed here will be implemented separated.
Hey guys! What you think about this layout:
Group entities
Great!!! But in order to have groups shown, it must be informed as metadata:
module.exports =
herbarium.entities
.add(List, 'List')
.metadata({ group: 'Core Entities' })
.entity
It would be interesting to understand a entity and its relationships not only in code but also having a more "visual" approach and have this information as part of Shelf experience.
For that we could extract metadata from Herbs
entity
and export to MermaidJS: