Fix response usecase doc

herbsjs / herbsshelf

Dynamically generated documentation for your domain

Other

8 stars 16 forks source link

Fix response usecase doc #58

Closed vitorgamer58 closed 1 year ago

vitorgamer58 commented 1 year ago

Only response usecase Request and response usecase

Fixes https://github.com/herbsjs/herbsshelf/issues/57

Proposed Changes

Fix push inside if(usecase.request)
Adds checker in ifs, because empty object is considered true by javascript
Checks if value is array before inserting into responseParams and adds logic to handle array

Readiness Checklist

Author/Contributor

[ ] If documentation is needed for this change, has that been included in this pull request
[ ] Remember to check if code coverage decrease, if so, please implement the necessary tests

Reviewing Maintainer

[ ] Label as breaking if this is a large fundamental change
[ ] Label as either automation, bug, documentation, enhancement, infrastructure, or performance

codecov[bot] commented 1 year ago

Codecov Report

Merging #58 (2336a1b) into main (e14199c) will increase coverage by 0.14%. The diff coverage is 100.00%.

:exclamation: Current head 2336a1b differs from pull request most recent head 0495cc6. Consider uploading reports for the commit 0495cc6 to get more accurate results

@@            Coverage Diff             @@
##             main      #58      +/-   ##
==========================================
+ Coverage   97.22%   97.36%   +0.14%     
==========================================
  Files           8        8              
  Lines          72       76       +4     
==========================================
+ Hits           70       74       +4     
  Misses          2        2

Impacted Files	Coverage Δ
src/shelf.js	`95.45% <100.00%> (+0.45%)`	:arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

herbsjs-robot commented 1 year ago

:tada: This PR is included in version 5.0.2 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

herbsjs-robot commented 1 year ago

:tada: This PR is included in version 5.1.0-beta.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket: