herbsjs / herbsshelf

Dynamically generated documentation for your domain
Other
8 stars 16 forks source link

BETA: Fix response usecase doc #59

Closed vitorgamer58 closed 1 year ago

vitorgamer58 commented 1 year ago

Only response usecase Request and response usecase

Fixes https://github.com/herbsjs/herbsshelf/issues/57

Proposed Changes

  1. Fix push inside if(usecase.request)
  2. Adds checker in ifs, because empty object is considered true by javascript
  3. Checks if value is array before inserting into responseParams and adds logic to handle array

Readiness Checklist

Author/Contributor

Reviewing Maintainer

codecov[bot] commented 1 year ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (beta@f12f040). Click here to learn what that means. The diff coverage is n/a.

:exclamation: Current head 80b392c differs from pull request most recent head d6c076b. Consider uploading reports for the commit d6c076b to get more accurate results

@@           Coverage Diff           @@
##             beta      #59   +/-   ##
=======================================
  Coverage        ?   86.31%           
=======================================
  Files           ?        9           
  Lines           ?       95           
  Branches        ?        0           
=======================================
  Hits            ?       82           
  Misses          ?       13           
  Partials        ?        0           

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

herbsjs-robot commented 1 year ago

:tada: This PR is included in version 5.1.0-beta.6 :tada:

The release is available on:

Your semantic-release bot :package::rocket: