search

hercules-390 / hyperion

Hercules 390
Other
248 stars 67 forks source link

Test for KMCTR28 causes crash on UNIX #169

Closed jphartmann closed 7 years ago

jphartmann commented 7 years ago

stack smashing detected : /usr/data/src/hercules/dbg/.libs/lt-hercules terminated

. . .

spinhawk has the same problem.

If, however, I compile with

define OPTION_KMCTR_DEBUG 1

The test case completes.

Looks like yet another parameter list mismatch on first sight. I fixed quite a few of those during my crypto updates in May, but admittedly didn't systematically test all function. So, I probably overlooked this one... I'll have a look at it.

jphartmann commented 7 years ago

It is usually an array that gets overflowed.

jphartmann commented 7 years ago

His calculation of the parameter block length is wrong for code 26..28. Fixed.

jphartmann commented 7 years ago

Fixed the abend, but the code is broken. Replaced his hokey calculations of parameter sizes. All cryptographic tests now run clean and have been validated against a z12.

Note that hyperion enforces the architecture level z2 so only the basic crypto is active (unlike spinhawk). You have to set archlvl z if you want the later assists.