hercules-390 / hyperion

Hercules 390
Other
248 stars 67 forks source link

Rule for all in tests fails #173

Closed fbi-ranger closed 7 years ago

fbi-ranger commented 7 years ago

Dear all,

Seems to be another issue in the make files:

make[2]: Leaving directory '/local/sys1/src/git/hercules/hyperion/crypto' Making all in tests make[2]: Entering directory '/local/sys1/src/git/hercules/hyperion/tests' make[2]: No rule to make target 'all'. Stop. make[2]: Leaving directory '/local/sys1/src/git/hercules/hyperion/tests' Makefile:2250: recipe for target 'all-recursive' failed make[1]: [all-recursive] Error 1 make[1]: Leaving directory '/local/sys1/src/git/hercules/hyperion' Makefile:1660: recipe for target 'all' failed make: *** [all] Error 2

ghost commented 7 years ago

On 25 Dec 2016, at 06:18, Ping Z notifications@github.com wrote:

My workaround:

out-of-source build. Something close to the follwing is also present

a friendly reminder to Mr. Ping Z

emailing with that writing style is considered all over the net as shouting …

we do not need that kind of behaviour around here

My best Regards

E.

jphartmann commented 7 years ago

Yes, out-of-source build is now a hard requirement on UNIX. We were not aware that it caused in-source builds to fail as Florian reported, but there is another report that "make clear" fails similarly when done in-source and that there is no failure when the instructions in BUILDING.txt are observed.

Enrico: The tracker does not take the huge font; it is what created the email that seems to have blown up. Since the original posting by Florian has been removed in the process, it looks as if Florian and Mr. Ping Z are the same identity as seen by github.

fbi-ranger commented 7 years ago

After analyzing the differences in the tests directory compared to previous releases, I found that there is now a makefile. It seems that is from the tests for SoftFloat. Deleting the file after configure step makes the make all work again. So my question is, if this make file, which is also part of Makefile.am is required or could be deleted.

jphartmann commented 7 years ago

I see no reason at all for this file, but others insist that it remains for building a distribution.

The Makefile.am has always been there; enabling the build of the makefile was an attempt at fixing the problem that creating a file in the tests directory causes a complete Hyperion rebuild on the next make.

If you or anyone else has any idea of how to cope with this auto#$* feature, please speak up.

Can you confirm that this problem remains for an out-of-source build?

If you pull and do autogen, you will notice that it has different instructions at the end.

fbi-ranger commented 7 years ago

That is correct Makefile.am does not do any harm. But isn't it that the makefile will be build when ./configure is run? Why do I need then the makefile in the git? To my understanding it simply interferes with build process.

jphartmann commented 7 years ago

Looks like it. But I need to understand why adding a file to tests make everything rebuild. Is there some general check for new files anywhere? Inquiring minds want to know.

fbi-ranger commented 7 years ago

Thanks for removing the file. Build is working again. The issue can be closed.