hercules-390 / hyperion

Hercules 390
Other
251 stars 70 forks source link

Unable to build Hyperion with shared libraries on FreeBSD 11.0. #205

Closed srorso closed 7 years ago

srorso commented 7 years ago

Whether or not --enable-shared is specified on ./configure, Hyperion is built as a single statically linked executable when building on FreeBSD 11.0. The executable is functional apart from crypto. Make check fails because runtest requires a dynamically linked/shared library version of Hercules.

At line 1310 et seq in autoconf/libtool.m4, three tests for FreeBSD are used to determine dynamic linker capabilities. The first test, freebsd1*), turns off dynamic linking. This test includes FreeBSD 1 but also turns off dynamic linking for FreeBSD versions 10.0 and up.

Changing the test to freebsd1 | freebsd1.*) allows FreeBSD 11.0 to build with dynamic libraries. Make check runs with no errors.

jphartmann commented 7 years ago

As we do not support static libraries any longer (no doubt thanks to crypto), this error should have triggered a message. Another nail in the coffin.

ivan-w commented 7 years ago

On 3/12/2017 6:05 PM, John P. Hartmann wrote:

As we do not support static libraries any longer (no doubt thanks to crypto), this error should have triggered a message. Another nail in the coffin.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hercules-390/hyperion/issues/205#issuecomment-285958384, or mute the thread https://github.com/notifications/unsubscribe-auth/ABjMWzN1J0HyVuPVyZMoTnbS3BajyfOBks5rlCXngaJpZM4MaUaW.

This doesn't help much does it ?

We are not here to talk about nails and coffin and not how YOU think things should work, but to make things work.

Hercules works fine (without crypto) when it is statically built. It has always been stated that crypto required a system capable of supporting dynamic libraries (legal issues).

The patch proposed solves the issue (it was a bug, nothing inherently flawed).

--Ivan

jphartmann commented 7 years ago

No, Ivan.

It was clearly stated that Hercules no longer supports static builds. This is not a decision of mine; just something I have learnt by rote.

And Ivan, the root problem is that the various autoxxx stuff was imported fourteen years ago and not updated since then. So when BSD got to version 10, something for version 1. kicked in and caused the bug. What should have happened is that something smarter kicked in and said, dear Sir, most politely may I ask why you with to build a static image in this day and age.

ivan-w commented 7 years ago

On 3/12/2017 6:28 PM, John P. Hartmann wrote:

No, Ivan.

It was clearly stated that Hercules no longer supports static builds. This is not a decision of mine; just something I have learnt by rote.

And Ivan, the root problem is that the various autoxxx stuff was imported fourteen years ago and not updated since then. So when BSD got to version 10, something for version 1. kicked in and caused the bug. What should have happened is that something smarter kicked in and said, dear Sir, most politely may I ask why you with to build a static image in this day and age.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/hercules-390/hyperion/issues/205#issuecomment-285959826, or mute the thread https://github.com/notifications/unsubscribe-auth/ABjMW2RfCyThhA8UrRJHga8UNWLW-omkks5rlCtQgaJpZM4MaUaW.

John,

I cannot remember ANY place stating that static builds were no longer supported ! There is NOTHING besides crypto that requires a dynamic build (all device and optional modules have provision for being statically linked EXCEPT for crypto).

The root problem is not that it hasn't been updated (and yes, it has, believe me)... It's that people expect it to run forever without being updated. It is being updated when it needs updating.

--Ivan

wrljet commented 7 years ago

Novice question: what is Crypto used for in Hercules?

Bill

ivan-w commented 7 years ago

On 3/12/2017 8:44 PM, Bill Lewis wrote:

Novice question: what is Crypto used for in Hercules?

Bill

Bill,

To implement the Message Security Assist Facilities (Basic and 1 to 5).

--Ivan

ivan-w commented 7 years ago

May this issue be closed ? I haven't tested it yet (since I do not have a FreeBSD install - as of yet).

Does it require extra testing ?

srorso commented 7 years ago

Hi Ivan,

There are a few that I need to review and close; when I am back on a computer. I will address.

Best regards, Steve Orso

+1 610 217 7050

On Mar 13, 2017, at 2:17 PM, Ivan Warren notifications@github.com wrote:

May this issue be closed ? I haven't tested it yet (since I do not have a FreeBSD install - as of yet).

Does it require extra testing ?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

ivan-w commented 7 years ago

On 3/13/2017 8:07 PM, Stephen Orso wrote:

Hi Ivan,

There are a few that I need to review and close; when I am back on a computer. I will address.

Best regards, Steve Orso

Plenty of time, don't worry - wasn't intending in pressing you ;) Was just enquiring !

Take your time man ! (And I'll try installing a FreeBSD instance VM myself....)

--Ivan