hercules-390 / hyperion

Hercules 390
Other
246 stars 69 forks source link

Minor bug fixes to ECPS:VM SIO instruction assist #221

Closed wably closed 7 years ago

wably commented 7 years ago

While investigating unrelated problem, I found two errors in the code within the SIO assist of ecpsvm.c. The first error is an incorrect equate name specified when checking for pending interruptions in the virtual device blocks:

 /*     if(B_VCUSTAT & VCUBUSY)     error      */
        if(B_VCUSTAT & VCUCHBSY) /* corrected  */

The second error is a typo where a halfword load was used against a byte field:

/* B_VDEVFLG2=EVM_LH(regs->GR_L(8)+VDEVFLG2);     error     */
   B_VDEVFLG2=EVM_IC(regs->GR_L(8)+VDEVFLG2);  /* corrected */

Additionally, during a clone and build from the Hyperion master repository earlier today, I found that code I had committed to control.c as a part of commit 3d97e8a had fallen off as a part of a later commit by someone else. I will re-commit my change to control.c as a part of this update, soon. This regression caused the LRA instruction assist to no longer be invoked.

wably commented 7 years ago

Closing; fixed by commit 0073054