hercules-390 / hyperion

Hercules 390
Other
251 stars 70 forks source link

Sysclear performed when test case times out. #239

Open srorso opened 6 years ago

srorso commented 6 years ago

In script.c function test_abort(), sysclear is done as part of cleaning up a test case that times out. This sets memory to zero and complicates understanding why the test case timed out. I propose that the two commands stopall and sysreset replace sysclear. The two commands will halt all processors and pending I/O operations but will not clear memory.

I will make and test the changes shortly.

Fish-Git commented 6 years ago

Another very good catch! Your proposed resolution seems perfectly reasonable to me. Thank you, Steve!

srorso commented 6 years ago

After consideration, the stopall/sysreset is a good start, but more could be done. A dump of memory and the processor context for each processor active during the test would be helpful, especially when investigating intermittent timeouts, such as the one described in #240.