search

hercules-390 / hyperion

Hercules 390
Other
246 stars 69 forks source link

dasdcopy: Fix error propagation in read path. #241

Open taralx opened 6 years ago

taralx commented 6 years ago

This was caught via -Wmisleading-indentation, which unfortunately has a bunch of misfires due to creative indentation style.

Fish-Git commented 6 years ago

GitHub is preventing those without write-access to even see the merge request!   :-o

Is there a way those of us with only read-access to at least view the patch?

Or is this for some reason secret/confidential information?

  `%-\`
Fish-Git commented 6 years ago

Never mind. The GitHub notification email contains links to the patch/diff.

(But still, what if you're not watching this repository and only reviewing/reading its issues? Sheesh, GitHub!)

taralx commented 6 years ago

I'm not sure why you had trouble seeing things -- the diff should be visible from the "Files changed" tab on this page.

Fish-Git commented 6 years ago

the diff should be visible from the "Files changed" tab on this page.

Yes, I can see that now. Thanks.

I don't know how I was trying to access it before that it wasn't letting me. I think it was the green GitHub "This branch has no conflicts..." box with the "Only those with write access..." message that may have been confusing me:

clipboard01

Sorry for the false alarm.