search

hercules-390 / hyperion

Hercules 390
Other
246 stars 69 forks source link

1Stop.cmd fails to identify 32-bit host when building Hyperion using VS2008. #248

Closed srorso closed 6 years ago

srorso commented 6 years ago

The 1Stop.cmd build script does not detect a 32-bit system when using Visual Studio 2008 because VS2008 does not set the %PLATFORM% environment variable when run on a 32-bit host system. The %PROCESSOR_ARCHITECTURE% variable does indicate 32-bit. See the comparable code in 1Stop.cmd for SoftFloat-3a for Hercules.

srorso commented 6 years ago

The 1Stop.cmd also fails to recognize a requirement to build a 32-bit binary when using Visual C++ 2008 Express Edition, which only supports 32-bit targets. (Yeah, there are hacks to change this.) So, in keeping with 1Stop.cmd being a "keep it simple" tool, it will build a 32-bit binary when faced with Visual C++ 2008, even if it is a hacked Express Edition or a Standard (or better) edition that can do 64-bit targets.

Fish-Git commented 6 years ago

Please see my response to your SoftFloat issue "1Stop.cmd fails to identify 32-bit host when building SoftFloat-3a using VS2008".

Perhaps my simple vstools.cmd batch file may be helpful to you?

srorso commented 6 years ago

Commit verified on Windows 7 VS2008 and Windows 10 VS2017.