search

hercules-390 / hyperion

Hercules 390
Other
252 stars 70 forks source link

async comm lines not working correctly with VM/ESA 1.5 #3

Closed dhdurgee closed 10 years ago

dhdurgee commented 10 years ago

A change was made to routine commadpt_execute_ccw in commadpt.c that causes async comm lines to stop working correctly with VM/ESA 1.5 here. For some reason the variable i was changed to u_int from int, which causes problems in the WRITE case where i was used to store the return code from read_socket and then incorrect actions are taken when tests are performed of the form if (i>0) there.

Either i should be changed back to type int or a new int variable, for example rc, should be used in the WRITE case so the tests work properly.

jphartmann commented 10 years ago

The return code from read() and write() is ssize_t, which is on most platforms typedef'ed to a signed long. Code should be changed accordingly.

Fish-Git commented 10 years ago

Fixed.