hercules-ci / arion

Run docker-compose with help from Nix/NixOS
Apache License 2.0
631 stars 47 forks source link

Add support for volumes to mount host paths #189

Closed qaifshaikh closed 1 year ago

qaifshaikh commented 1 year ago

Addresses https://github.com/hercules-ci/arion/issues/188

qaifshaikh commented 1 year ago

We use this already for colima in our setups. It works quite well, but we've patched it to an old revision of Marion.

Precisely https://github.com/hercules-ci/arion/blob/a95066a8449765df2ad9c3a0d0c8307f5f52cbd7/src/nix/modules/composition/docker-compose.nix

so I'll need someone to share their input on this please 🙏🏻

qaifshaikh commented 1 year ago

nudge @roberth for review

srid commented 1 year ago

This would be good to have. I've been using docker-compose.raw.volumes.

roberth commented 1 year ago

bors r+

bors[bot] commented 1 year ago

Timed out.

roberth commented 1 year ago

bors r+

bors[bot] commented 1 year ago

Timed out.