search

hercules-ci / arion

Run docker-compose with help from Nix/NixOS
Apache License 2.0
667 stars 48 forks source link

Improve service.networks #200

Closed pedorich-n closed 1 year ago

pedorich-n commented 1 year ago

This PR adds more options to service.networks, according to the spec it exposes:

A more complex example using these options is added, by modifying the existing traefik example. I wasn't able to run the tests locally on my non-NixOS machine, but from what I can see, it just tests if the host is available. That is still true and works, I checked by running arion up from the examples/traefik folder.

roberth commented 1 year ago

bors try

bors[bot] commented 1 year ago

try

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here. For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

pedorich-n commented 1 year ago

Rebased. I also realized I was looking at the old spec and missed a couple of parameters: link_local_ips and priority.

roberth commented 1 year ago

old spec

old... Should arion refer to something more recent?

pedorich-n commented 1 year ago

I think now it refers to the most recent version.

But while digging for information, I found https://www.compose-spec.io/ and the spec is at https://github.com/compose-spec/compose-spec/blob/master/05-services.md.

The Compose Specification is a developer-focused standard for defining cloud and platform agnostic container-based applications

Since arion supports docker and podman, maybe it should point to a generic spec? podman-compose says it implements this spec and docker-compose refers to it too. And you can pin it to the specific commit and update from time to time, so you know Arion docs always have valid links.

image image

pedorich-n commented 1 year ago

Anyway, I think the conversation has gone a little off track 😅 Here's the PR using compose-spec instead of docker-compose for docs: https://github.com/hercules-ci/arion/pull/202. We can continue the docs-related conversation there.

Is there anything else I can do to get this PR merged?

roberth commented 1 year ago

bors r+

bors[bot] commented 1 year ago

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here. For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.