hercules-ci / arion

Run docker-compose with help from Nix/NixOS
Apache License 2.0
622 stars 48 forks source link

Disable DHCP in NixOS-based containers #227

Open roberth opened 8 months ago

roberth commented 8 months ago

This seems like something we should disable in all cases, as DHCP is not really a container level concern, and as far as I know the container runtime should configure the container network, and not through an indirection like DHCP.

I think we should have a file analogous to service/nixos-init.nix except its configuration is always enabled. service/nixos-defaults.nix? And then a module nixos/defaults.nix that actually does the disabling. Does that make sense?

Originally posted by @roberth in https://github.com/hercules-ci/arion/issues/199#issuecomment-1627437487