Don't process sources from nix store? - Githubissues

hercules-ci / gitignore.nix

Nix functions for filtering local git sources

The Unlicense

245 stars 20 forks source link

Don't process sources from nix store? #24

Open roberth opened 5 years ago

roberth commented 5 years ago

Store paths are typically already freshly fetched clean repos

Advantages:

no interference from ~/.gitconfig etc
smaller code path footprint for projects that use dependencies that use gitignore
- much smaller impact for bugs like #22 (Nix 2.3 builtins.match behavior change)
performance

Disadvantages:

what if the repo gitignores some of its own contents...

Requirements:

9 should still be possible

Unresolved:

Where to implement this logic?
Should this be implemented here or in pkgs.cleanSourceWith?