search

hercules-ci / gitignore.nix

Nix functions for filtering local git sources
The Unlicense
245 stars 20 forks source link

whitelisting feature? #35

Closed chessai closed 4 years ago

chessai commented 4 years ago

there are some files in a .gitignore which nix might need to build, such as config files with credentials that shouldn't be checked in. would you be open to having this as a feature? i'm imagining an argument which is just a list of items to be kept around.

roberth commented 4 years ago

Please don't use gitignoreSource on credentials. They will be world-readable in the Nix store.

If you do want to take the risk, I just wrote a pr to document gitignoreFilter. https://github.com/hercules-ci/gitignore.nix/pull/36

chessai commented 4 years ago

Ah, crap. I forgot about that issue. I'll close this, thanks.