search

hercules-ci / gitignore.nix

Nix functions for filtering local git sources
The Unlicense
242 stars 19 forks source link

Invalid regular expression for the gitignore pattern `*.*\~` #49

Open soareschen opened 3 years ago

soareschen commented 3 years ago

When I have *.*\~ as an entry in .gitignore, The library produces the following error:

error: invalid regular expression '(^|.*/)[^/]*\.[^/]*\~'

This has been tested on the latest commit of gitignore.nix on master.

roberth commented 3 years ago

Just to be sure that it's not https://github.com/hercules-ci/gitignore.nix/issues/40, did you update all references to the gitignore library? A dependency may reference an old version that didn't fix #40 yet.

roberth commented 3 years ago

I don't think you need the \ before ~.

soareschen commented 3 years ago

I am using a pinned version of gitignore.nix directly, so it should be in latest version already. Specifically, commit c4662e662462e7bf3c2a968483478a665d00e717.

Anyway this is not a big issue, as I simply removed the offending line in .gitignore. I just thought of reporting this issue so that you can be made aware of this.