hercules-team / augeas

A configuration editing tool and API
http://augeas.net/
GNU Lesser General Public License v2.1
486 stars 199 forks source link

lenses: Allow whitespace at the end of kernel commnd line #798

Closed rwmjones closed 1 year ago

rwmjones commented 1 year ago

Reported-by: Yongkui Guo Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2159282 Signed-off-by: Richard W.M. Jones rjones@redhat.com

rwmjones commented 1 year ago

I'm not sure if you're asking if we test the feature in general (yes), or if we tested before whitespace at the end of a command line (no), or if I added a new test for this (also no) ?

igalic commented 1 year ago

if we already have tests for the feature, then we should extend the tests, too

(i'm not going to ask people to add tests where there are none to begin with)

rwmjones commented 1 year ago

The updated commit adds a test for a command line ending in whitespace. Hope I did it right!