hercules-team / augeas

A configuration editing tool and API
http://augeas.net/
GNU Lesser General Public License v2.1
486 stars 199 forks source link

lenses/fstab.aug: Allow comma after the last option #838

Closed tupyy closed 4 months ago

tupyy commented 4 months ago

This PR adds a new lens that allows a comma after the last option:

/dev/mapper/foo-bar / xfs defaults, 0 0

Fixes: https://github.com/hercules-team/augeas/issues/832

Signed-off-by: cosmin@redhat.com

rwmjones commented 4 months ago

Please squash the commits into one (you'll have to force push to your branch).

Also needs a Signed-off-by in the commit message.

Also remove fstab - prefix and either replace it with nothing or with fstab:. See existing commit messages in the project (which are not very consistent, but nothing uses -).

Also add Fixes: line.

tupyy commented 4 months ago

@rwmjones done

rwmjones commented 4 months ago

You need to add the Fixes:. Also git commit messages are plain text, so using back ticks is not necessary.

rwmjones commented 4 months ago

Also it should be Signed-off-by, see https://www.kernel.org/doc/html/latest/process/submitting-patches.html

tupyy commented 4 months ago

ptal

rwmjones commented 4 months ago

This looks good now. I also applied it to my local tree and ran the tests and those pass.