Rewrote the extension code in CFFI

hercules-team / python-augeas

Python bindings for Augeas

GNU Lesser General Public License v2.1

44 stars 31 forks source link

Rewrote the extension code in CFFI #14

Closed thedrow closed 7 years ago

thedrow commented 8 years ago

This has multiple advantages:

It allows us to support PyPy. The match() method used CPython specific API with ctypes and that didn't work on PyPy.
It's faster than ctypes even on CPython.

It does require cffi and setuptools but all python developers have those installed. All the tests pass. Let me know if something is wrong so I can fix it.

raphink commented 8 years ago

I'll try to take some time to review later. Could you squash into passing commits only already?

thedrow commented 8 years ago

@raphink Of course I can :)

thedrow commented 8 years ago

@raphink Done :)

thedrow commented 8 years ago

@raphink Ping?

thedrow commented 8 years ago

@raphink I managed to free the matches array so it should all be good to merge. No more issues. I'll add more features later.