search

hercules-team / python-augeas

Python bindings for Augeas
GNU Lesser General Public License v2.1
44 stars 31 forks source link

Bandaid for broken build #22

Closed lutter closed 7 years ago

lutter commented 7 years ago

This tries to address the broken build; it's not entirely right as the include path for libxml should be taken from 'pkg-config --cflags libxml-2.0' rather than be hardcoded.

This should address issues #21 and #20

thedrow commented 7 years ago

The reason I didn't include this in setup.py is because I was not sure libxml2 is always at the same place on all Linux distributions. This fix works for Ubuntu. Can we please verify it works on other distributions as well?

lutter commented 7 years ago

@thedrow that's why I called that a bandaid .. it should work on Ubuntu and CentOS/Fedora (and since building seems universally broken, it's an improvement either way)

Can you merge this and push out a new release to unblock Let's Encrypt and other users of python-augeas ? You should then try to figure out how to do this correctly (using pkg-config)

Please don't ever make a release with questions like this unresolved.