hercules-team / python-augeas

Python bindings for Augeas
GNU Lesser General Public License v2.1
44 stars 31 forks source link

Always return bytes from enc() #27

Closed yan12125 closed 7 years ago

yan12125 commented 7 years ago

Fix #26

pspacek commented 7 years ago

Tests can be re-run when Python 3.2 support is removed.

felixonmars commented 7 years ago

Confirmed that this patches fixes certbot-apache's test suite for me.

pspacek commented 7 years ago

29 was merged so this PR will most likely pass CI tests when it is rebased on top of current master (to remove the Python 3.2 from .travis-cii.yml).

yan12125 commented 7 years ago

Thanks @pspacek! I rebased this PR and Travis is satisfying :)

thedrow commented 7 years ago

Should be fixed in 1.0.3 which is being released now :)

pspacek commented 7 years ago

Have you checked the dec() as well? The same fix might be missing in there.

thedrow commented 7 years ago

I fixed dec() as well.

pspacek commented 7 years ago

Great, thanks!

yan12125 commented 7 years ago

Thanks!