search

hercules-team / python-augeas

Python bindings for Augeas
GNU Lesser General Public License v2.1
44 stars 31 forks source link

Add Python 3.6 and drop 2.6 and 3.3 #33

Closed hugovk closed 6 years ago

hugovk commented 6 years ago

Resolves #31.

Also removed some unused imports, variables and semicolons.

hugovk commented 6 years ago

@thedrow Hello, any thoughts on this PR? Thank you!

thedrow commented 6 years ago

Thanks!

lutter commented 6 years ago

How do we make sure that this doesn't break users, especially Let's Encrypt ? RHEL6 still has python-2.6.6 on it, and we can't break that.

Before this gets released, please coordinate with @bmw and @jinhooi to make sure it does not break them - and if it does, please revert this

hugovk commented 6 years ago

One option is they pin to the currently released version that still supports 2.6.

lutter commented 6 years ago

I am not a fan of forcing users to pin, especially since it locks them out from other improvements, e.g. new augeas API calls. It also requires that they learn about what to pin to and therefore creates more friction in using the bindings.

For something as simple as language bindings, it's much better to keep it working across as many versions of Python as possible, especially if those versions are still in active use.

bmw commented 6 years ago

Thanks for pinging me about this. Feel free to go ahead and make this change as the only installation mechanism we support for Python 2.6 users has all of our dependencies pinned to specific versions and we're planning to drop support for Python 2.6 ourselves in the coming months.

lutter commented 6 years ago

Awesome ! Thanks for letting us know.