[Makefile] Add some basic tests for litmus7

herd / herdtools7

The Herd toolsuite to deal with .cat memory models (version 7.xx)

Other

219 stars 56 forks source link

[Makefile] Add some basic tests for litmus7 #845

Open relokin opened 4 months ago

relokin commented 4 months ago

I am not sure this ready for prime time but it's high time we added some basic regression testing for litmus7. So I'm posting this just to start a conversation really. How can we improve this?

Known limitations of make litmus-test :

[ ] Assumes it runs on an Arm machine without checking. Checking and exiting is rather straightforward.
[ ] Does not run any litmus tests, so the check is limited to whether the generated C code compiles.
[ ] Two regressions that depend on kvm-unit-tests, automatically clone, and compile kvm-unit-tests but don't clean-up the kvm-unit-tests directory.

maranget commented 4 months ago

Thanks @relokin. I have already found a problem thanks to this PR: option -mode presi does not work without -ascall true.

maranget commented 4 months ago

With the patch above make litmus-test works for me on a Macbook pro M1.

maranget commented 2 months ago

Hi @relokin. What about applying the patch above and merging? There still are three tasks pending, but the PR already looks quite useful as it is, since you apparently we have used it at least three times...

murzinv commented 2 months ago

Known limitations of make litmus-test :

[ ] Assumes it runs on an Arm machine without checking. Checking and exiting is rather straightforward.

~Then probably reflect it a target name something like litmus-aarch64-test or litmus-test.aarch64?~

murzinv commented 1 month ago

With some minor adjustment I can run litmus-test on my x86_64 Linux box :smile:

maranget commented 1 month ago

Hi @murzinv. This looks very interesting, would you submit these adjustments here?

murzinv commented 1 month ago

Hi @murzinv. This looks very interesting, would you submit these adjustments here?

https://github.com/herd/herdtools7/commit/5194529ec8ba699e2ce0d3e36f79bf11d4b7bbbf

Please, note that fix make litmus-cata-aarch64-ifetch-test fail. I do not know if it is intended to work with -mode std or not and what it the best way to address the issue...