search

herd / herdtools7

The Herd toolsuite to deal with .cat memory models (version 7.xx)
Other
215 stars 54 forks source link

[asl] Statically link ASL stdlib. #892

Closed HadrienRenaud closed 1 month ago

HadrienRenaud commented 1 month ago

This PR statically links ASL stdlib.

This is following some troubles I had where the tests were using an installed version of the stdlib, and not the one in dev.

I'm open to more flexibility or amending this PR.

maranget commented 1 month ago

I like this PR, do you consider it ready?

HadrienRenaud commented 1 month ago

I've just pushed a small refacto to make it look nicer, but otherwise I think it's ready. Do you want to merge @maranget?

maranget commented 1 month ago

Yes, I'll merge now. Thanks @HadrienRenaud. The new code is much simpler than the former one, as we avoid the duplication of the search patch code, which I felt uncomfortable with. It is not that nice to carry a string in code... but I guess stdlib will not grow much and that the size of this string will not increase much.