herd / herdtools7

The Herd toolsuite to deal with .cat memory models (version 7.xx)
Other
225 stars 62 forks source link

[asl] Add missing EOF in cram tests #950

Closed yuxiliu-arm closed 2 months ago

yuxiliu-arm commented 2 months ago

Otherwise, make test may generate a diff + warning: here-document at line N delimited by end-of-file (wanted `EOF') for some shells.

HadrienRenaud commented 2 months ago

Hi @yuxiliu-arm,

Thank you for this PR. Wondering what shell makes this diff? But otherwise looks good to me.

yuxiliu-arm commented 2 months ago

Hi, I'm assuming dune cram test uses the encompassing shell, which for me is:

$ bash --version
GNU bash, version 5.2.32(1)-release (aarch64-apple-darwin23.6.0)

I wasn't getting the error on a Linux machine before. I don't have the exact shell version of that at the moment.

HadrienRenaud commented 2 months ago

I think dune uses sh (see here), which on my machine is an alias for bash, but maybe that's the difference?