hereisSwapnil / ExamTime

Share/Download notes PDF helps during exams
https://exam-time.vercel.app
MIT License
58 stars 120 forks source link

Implement Feature: Remove the request when someone uploads notes for it #163

Closed Praveenkumar5048 closed 1 month ago

Praveenkumar5048 commented 1 month ago

Description

I am pleased to submit this pull request addressing Feature Request #94

AS per feature proposal and your guidelines, i have included a button for each request in view notification page. with this button users can contribute/upload notes specific to that request. After successful upload the corresponding request is removed/deleted from the database. The major change i have made in the code is updating the route for upload page. older route path :- <Route path="/upload" element={UploadPage } /> updated route path :- <Route path="/upload/requestId?" element={UploadPage } /> This route correctly deals with normal notes upload and notes upload specific to user request.

This feature enhances our application avoiding duplicate uploads.

I have thoroughly tested these changes to ensure their functionality and compatibility with the existing codebase. I am open to any feedback or suggestions for improvement and am committed to addressing any concerns raised during the review process.

Thank you for considering this contribution. I look forward to collaborating with you to further enhance the ExamTime platform.

Resolves: [#94]

Checklist

vercel[bot] commented 1 month ago

@Praveenkumar5048 is attempting to deploy a commit to the swapnilsingh99's projects Team on Vercel.

A member of the Team first needs to authorize it.

Praveenkumar5048 commented 1 month ago

Hello sir @hereisSwapnil , I could see you have successfully merged my pulled request. But I think while solving merge conflicts you have missed one changes that I had made. I had changed the upload page route from "/upload" to "/upload/:requestId?" in client/src/App.jsx , but you didn't consider this change. I urge you to change this route path, or else there would be problem in navigating from notification page to upload page after the user clicks "Contribute" button. Making this change won't affect any other part of the code. I hope you do this change in the main branch as soon as possible.