search

heremaps / flexible-polyline

Flexible Polyline encoding: a lossy compressed representation of a list of coordinate pairs or triples
MIT License
91 stars 77 forks source link

initial commit of Matlab version #48

Closed RenoFilla closed 2 years ago

RenoFilla commented 2 years ago

initial commit of Matlab version

Signed-off-by: Reno Filla reno.filla@gmx.net

lene commented 2 years ago

Thanks for this! Since you labeled it as "initial commit", I am not sure if you consider it ready for review yet. Either way, would you mind adding some tests to ensure code correctness, please?

RenoFilla commented 2 years ago

Thanks for this! Since you labeled it as "initial commit", I am not sure if you consider it ready for review yet. Either way, would you mind adding some tests to ensure code correctness, please?

I only commit working code. ;-) It's been used heavily at my day job. I don't know how to add automated tests. It works as intended, take any example you want.

RenoFilla commented 2 years ago

Either way, would you mind adding some tests to ensure code correctness, please?

Test added.

RenoFilla commented 2 years ago

If there is anything preventing this from being accepted please notify me. The code is final, it is proven to work, tests are added, everything signed as required.

If I might add: the amount of hours I had to spend attending to issues to get the code approved (even though it still isn't) outnumbers the amount of hours spent on actual code development by factor 2. Not necessarily meant as criticism, basically just an observation. I do agree that at least the requirement to develop a test script was a good one that will be beneficial for future releases.