heremaps / flexible-polyline

Flexible Polyline encoding: a lossy compressed representation of a list of coordinate pairs or triples
MIT License
91 stars 77 forks source link

Porting python implementation to ruby #58

Closed ProGM closed 1 year ago

ProGM commented 2 years ago

Hi there,

This is a porting of the python implementation in Ruby. I need this library for our company projects in Ruby on Rails 💎

I hope you'll decide to merge this ;)

Implementation details:

sergykorets commented 1 year ago

Please merge

ProGM commented 1 year ago

@roshats Hi, I've made all the requested changes. Let me know if it's all fine or it's ready to be merged :)

roshats commented 1 year ago

Thanks @ProGM .

@VeaaC , I think me can merge this Pull Request and publish ruby gem.

VeaaC commented 1 year ago

@ProGM the commits needs to be signed, then I can go ahead an merge ( https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification )

ProGM commented 1 year ago

@VeaaC @roshats Commits signed ;)

VeaaC commented 1 year ago

Merging. @roshats / @ProGM can you also add some CI to test against the shared conversion tests in https://github.com/heremaps/flexible-polyline/tree/master/test ?