search

heremaps / gradle-jenkins-jobdsl-plugin

A plugin for Gradle to manage Jenkins Job DSL projects.
https://plugins.gradle.org/plugin/com.here.jobdsl
Apache License 2.0
53 stars 9 forks source link

No signature of private method applyDefaultConfiguration() visible in clousure #117

Closed vudzkostek closed 5 years ago

vudzkostek commented 5 years ago

I get: javaposse.jobdsl.dsl.DslScriptException: (PipelineBuilder.groovy, line 71) No signature of method: package.HourlyPipelineBuilder.applyDefaultConfiguration() is applicable for argument types: (package.TriggerJobBuilder) values: [package.TriggerJobBuilder@7584ddc1]

HourlyPipelineBuilder extends com.here.gradle.plugins.jobdsl.util.PipelineBuilder TriggerJobBuilder extends com.here.gradle.plugins.jobdsl.util.PipelineJobBuilder

applyDefaultConfiguration is a private method in PipelineBuilder but it is called from clousure in build() and I think this is an issue related to these bugs in groovy: https://issues.apache.org/jira/browse/GROOVY-3073 https://issues.apache.org/jira/browse/GROOVY-3010

I would change signature of method to 'protected final' but I am not an expert

mnonnenmacher commented 5 years ago

Your fix is part of 3.5.0 which was just released.

vudzkostek commented 5 years ago

Great! thank you