search

heremaps / here-sbt-bom

SBT BOM is the plugin for SBT for dealing with Maven BOM in SBT projects
Other
16 stars 5 forks source link

Standardize the published artifacts #8

Closed julienrf closed 6 months ago

julienrf commented 7 months ago

See #6 and #4 for context.

The released artifacts followed a unique pattern, see https://repo1.maven.org/maven2/com/here/platform/sbt-bom_2.12_1.0/1.0.4/sbt-bom-1.0.4.pom. In the path, we use sbt-bom_2.12_1.0 and then in the file name it is sbt-bom-1.0.4.pom, and finally in the POM content the artifactID is sbt-bom_2.12_1.0.

I am not sure exactly why the artifactID was changed like that in #4 (and also #1), but that artifactID is not consistent with the file name.

I think the way to go is to use sbt 1.9.x, which will publish two files:

That should at least fix #6, but I am not 100% it will also solve the problem that led to #4. I believe the only way to test it is to cut an RC release (publishLocal uses the local Ivy repository).

molekyla commented 6 months ago

CI checked here: https://github.com/heremaps/here-sbt-bom/pull/10. So merged despite tests are failed

molekyla commented 6 months ago

@julienrf Thanks for the contribution!