search

heremaps / maps-api-for-javascript-examples

Self-contained examples for Maps API for JavaScript v3.
https://developer.here.com/javascript-apis/documentation/v3/maps
Other
194 stars 430 forks source link

Updated indoor map example based on user feedback #145

Closed hnativ13 closed 1 year ago

dbacarel commented 1 year ago

Hi @hnativ13, the diff shows changes that were already introduced in a previous commit. Could you please check that your branch is correctly rebased?

hnativ13 commented 1 year ago

Hi @hnativ13, the diff shows changes that were already introduced in a previous commit. Could you please check that your branch is correctly rebased?

Hello @dbacarel - it looks like the branch was rebased correctly, I'm not sure why my commit captured a commit from 11 November 2022. Do I need to remove this change that was already introduced in a previous commit from my pull request?

dbacarel commented 1 year ago

strange, in order to not mess up the history, would you mind creating a separate PR? I see that the changes are few and very minor

hnativ13 commented 1 year ago

strange, in order to not mess up the history, would you mind creating a separate PR? I see that the changes are few and very minor

Hi @dbacarel - sorry, this took me a little longer than I thought, but here it is - a separate PR: https://github.com/heremaps/maps-api-for-javascript-examples/pull/147