search

heremaps / maps-api-for-javascript-examples

Self-contained examples for Maps API for JavaScript v3.
https://developer.here.com/javascript-apis/documentation/v3/maps
Other
194 stars 430 forks source link

Indoor map example update based on user feedback #147

Closed hnativ13 closed 1 year ago

hnativ13 commented 1 year ago

Hi @dbacarel - so this is the new PR. Can you please review it?

dbacarel commented 1 year ago

@hnativ13 the history is once again compromised + your previous changes about passing platform instance to addVenueToMap are gone

hnativ13 commented 1 year ago

@hnativ13 the history is once again compromised + your previous changes about passing platform instance to addVenueToMap are gone

Oh my, sorry, I thought this was the one you requested to revert. Shall I commit it again?

dbacarel commented 1 year ago

@hnativ13 , I created a separate branch with the expected changes https://github.com/heremaps/maps-api-for-javascript-examples/pull/148 and merged it. Closing this one