search

heremaps / oksse

An extension library for OkHttp to create a Server-Sent Event (SSE) client.
Apache License 2.0
228 stars 27 forks source link

Library Version with HTTP2 support doesn't appear to be published on jitpack #33

Open fkurniaw opened 3 years ago

fkurniaw commented 3 years ago

When I bundle the oksse library as part of my android app, I get an issue where the list of protocols available is limited to only http/1.1

However, I've been explicitly passing in an OkHttpClient that has h2 as part of the protocols

Seems like the PR here isn't included in the library that was published to jitpack https://github.com/heremaps/oksse/pull/25

lbdroid commented 3 years ago

This is a dead project. Use the SSE features built into okhttp as okhttp-sse.

vitalyster commented 3 years ago

@lbdroid okhttp-sse does not reconnect - https://github.com/square/okhttp/issues/5471

lbdroid commented 3 years ago

@vitalyster : Nothing stopping you from performing your own reconnect from onClosed() and onFailure().

vitalyster commented 3 years ago

@lbdroid nothing stopping me writing my own library, but SSE support in okhttp-sse is broken and incomplete, while everything is ok in oksse

lbdroid commented 3 years ago

Its not broken, and incomplete doesn't matter if it does what is needed. oksse is both broken and unsupported, which makes it a non-starter no matter how you look at it.

vitalyster commented 3 years ago

@lbdroid automatic reconnection is a key feature of SSE standard, so okhttp-sse is broken(incomplete) and can not be used until the issue is not fixed

lbdroid commented 3 years ago

Cry me a river. Its ONE LINE in your own code to make it automatically reconnect.

vitalyster commented 3 years ago

Go and fix okhttp-sse then and stop that flood

lbdroid commented 3 years ago

Why would I waste my time fixing something that doesn't need to be fixed?

vitalyster commented 3 years ago

It should be fixed, because that library does not implement key feature of the standard it tries to implement

lbdroid commented 3 years ago

What is your point? Are you advertising for this broken and unmaintained crap project?

vitalyster commented 3 years ago

This project works perfectly and I'm pointing out key feature, while you are repeating FUD.

lbdroid commented 3 years ago

This project hasn't seen a commit in 3 years. It does NOT work, and it uses a horrendously out of date and non-secure version of okhttp.

vitalyster commented 3 years ago

It works absolutely correct and you can use any version of okhttp with it, learn how to manage dependencies before writing misinformation.

lbdroid commented 3 years ago

Come back when you reach adulthood.