search

heresy / angular2-social-login

Simple client side social authentication for Angular2 application.
30 stars 38 forks source link

Github login #20

Open roydekleijn opened 7 years ago

roydekleijn commented 7 years ago

Hi,

It would be create if we can add Github login.

Can you give me some pointers on how to extend this awesome feature.

Roy

roydekleijn commented 7 years ago

can we pls collaborate on this ?

kpsrinivas commented 7 years ago

Sure. Let me know if you have a push ready.

ip4368 commented 7 years ago

I think I know how the library works. I think I can implement it. Just wondering would you like Github App or OAuth for Github integration? For just basic info like email and name, OAuth should work, just depend on which one you are looking for.

roydekleijn commented 7 years ago

OAuth would be super awesome!

ip4368 commented 7 years ago

I just realized that the OAuth 2 that Github provided didn't support implicit flow. Creating a fully client side auth will sacrifice security. This may be solved by implementing a server side end point, but will not be fully client side. So I guess this is not very possible in this project, at least for now, until Github support implicit flow.

roydekleijn commented 7 years ago

Does the same apply for Github App ?

ip4368 commented 7 years ago

Yeah, apparently apparently their Github app integration server is the resource server, and OAuth is the authentication server (which make sense in OAuth architecture), so all authentication basically need to go through the OAuth server.