search

herikw / home-assistant-custom-components

Atag One Custom components for Home-Assistant
GNU General Public License v3.0
11 stars 5 forks source link

Changed error handling so the climate component is always loaded. #15

Closed TheNr1Guest closed 4 years ago

TheNr1Guest commented 5 years ago

My changes: 1) The climate component will now always be loaded. In my case my connection with the Atag One is unstable for some reason and when restarting Home Assistant I would often get an unavailable climate control which could only be fixed by another restart. Now with my changes, when the first API call fails, I will still see the component (with empty data). And after the first successful call it will get updates and it will be functional again without me needing to reboot Home Assistant. 2) I reduced some logging, I removed the full stack traces with cleaner messages: 2019-08-23 22:10:07 ERROR (SyncWorker_8) [custom_components.atagone.climate] Atag ONE Api Error: Remote end closed connection without response

TheNr1Guest commented 4 years ago

@herikw Any possibility of merging this pull request?

daranto commented 4 years ago

Hey, thanks for the better error handling and that the climate now always loads. Works perfekt. Would be nice to merge the changes.

herikw commented 4 years ago

There's a new release which support dynamic IP address resolution and improved retry connection mechnism.