Increased robustness - Githubissues

TheNr1Guest commented 4 years ago

Scenario I have an AtagOne which connection for some unknown reason is terrible. Lots of timeouts.

Changes

I added additional checks to see if we actually have a valid response which we can parse, previously the component would crash resulting in an unavailable entity in HA. The only way to fix this was to keep restarting HA until you were lucky enough the connection was established during startup of HA. Now it simply loads an empty climate control if the connection during startup fails. It will load and function properly when the next connection attempts succeed.
The component would keep being named climate.atagone even when a custom name was provided.

TheNr1Guest commented 4 years ago

I initially added a similar PR which was closed since new retry mechanisms were introduced: https://github.com/herikw/home-assistant-custom-components/pull/15

I just wanted to add that these new mechanisms would still allow for an unavailable entity in HA and therefor I see this PR to be useful for people with a bad connection to their AtagOne.

TheNr1Guest commented 3 years ago

@herikw Is it possible to merge this PR? Or at least give your thoughts about it. Much appreciated!

herikw / home-assistant-custom-components

Increased robustness #26