search

herimedia / norconex-committer-elasticsearch-rest

:warning: DEPRECATED in favor of https://www.norconex.com/collectors/committer-elasticsearch/releases#a4.0.0-SNAPSHOT. (WAS: An elasticsearch committer for http://www.norconex.com/collectors/collector-http that uses elasticsearches REST interface [via Jest].)
0 stars 0 forks source link

Change group to com.norconex.collectors #2

Closed danizen closed 7 years ago

danizen commented 7 years ago

Noticed that on a search on Maven central, the group is "com.norconex.collectors" even for the collectors, and I am suggesting you change it for consistency.

Another thing could be to ask Paul whether it might be appropriate to put it in another group, perhaps "com.norconex.collectors.contrib" to distinguish it from the supported work.

Anyway, "com.norconex.committers" is neither consistent nor semantically clear, but I still very much want to use this code ;)

niels commented 7 years ago

Huh, that's an unexpected convention; thanks for pointing out the discrepancy.

Better conventions and perhaps even an official home for contributed code would be great. Ideally, this would be integrated with the existing download and (auto-generated) documentation pages for the core components.

At the same time however, one wouldn't want to put even more work on Pascal's shoulders! @essiembre, would there be any interest on Norconex' part to provide such a repository of contributions?

essiembre commented 7 years ago

@niels There is this page already: https://www.norconex.com/collectors/committer-elasticsearch/contributions

Do you have something else in mind?

As for integrating your code into the main download, are you OK if I take whatever code I need from your contribution to do so when I get the chance?

niels commented 7 years ago

@essiembre I think that page is perfectly sufficient for most. I was wondering if it would also be possible to include contributions in the document generation process rather than having them hosted entirely externally. For example, it would be great if there was a page like https://www.norconex.com/collectors/committer-elasticsearch/releases for each contribution as well.

On the downside, I don't know how much effort this would require on your end and I am also concerned that if contributions appear "too official", users may end up sending support queries your way. Having contributions live completely outside of norconex.com better communicates that they are external and unsupported components.

With regards to pulling in my code: yes, please feel free to integrate it into the main codebase at your convenience!

danizen commented 7 years ago

@essiembre, You may want to wait before taking what is here - I have work almost finished to add HTTP Basic Auth to this elasticsearch rest committer. We protect ours by saying any method other than GET requires a password to given patterns.

It is working, but I have to copy it out of https://github.com/danizen/trynorconex into a fork of this repository, and add some tests.

niels commented 7 years ago

@danizen, HTTP Auth should already be working if you just embed username and password in the serverUrl as documented here. We are using it in production. Or are you looking to add more complicated credentials management with encryption?

danizen commented 7 years ago

@niels, I thought it would be nice to do something like @essiembre did with the password for mongodb in the MongoDataSourceFactory (I think it is) in the importer. I guess I did a bunch of work for nothing - I will submit the pull request anyway, even though some adjustment is needed to javadoc.