search

hermannpencole / nifi-config

Automatically deploy and configure Template on Nifi
Apache License 2.0
55 stars 39 forks source link

Fixing output/input port fail on undeploy #43

Closed luzhanov closed 6 years ago

luzhanov commented 6 years ago

Fix for issue #37 based on the proposed solution from @ennui93

codecov[bot] commented 6 years ago

Codecov Report

Merging #43 into master will increase coverage by 1.21%. The diff coverage is 70.21%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #43      +/-   ##
========================================
+ Coverage   58.78%    60%   +1.21%     
========================================
  Files          18     18              
  Lines         985   1025      +40     
  Branches      179    185       +6     
========================================
+ Hits          579    615      +36     
  Misses        343    343              
- Partials       63     67       +4
Impacted Files Coverage Δ
...pencole/nifi/config/service/ConnectionService.java 75.43% <67.56%> (-15.48%) :arrow_down:
...ncole/nifi/config/service/ProcessGroupService.java 69.61% <80%> (+5.4%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fa67f1b...bc6eb1e. Read the comment docs.

ennui93 commented 6 years ago

We've tested this fix on our NiFi deployments and can confirm that it works as expected.