search

hermannpencole / nifi-config

Automatically deploy and configure Template on Nifi
Apache License 2.0
55 stars 39 forks source link

[feature] allow specifying password using env variable #50

Closed jaroslawk closed 6 years ago

jaroslawk commented 6 years ago

Hermann I would like to add an ability to specify Nifi password using system enviable.

We are running nifi-config in a shared environment and using command line parameter exposes password in a plain text when one issued:

$ ps -ax | grep java Warning: bad syntax, perhaps a bogus '-'? See /usr/share/doc/procps-3.2.8/FAQ 6924 ? Sl 0:01 java -jar ../nifi-config/target/nifi-deploy-config-1.1.xxxx.jar -noVerifySsl -readTimeout 120000 -connectionTimeout 120000 -nifi https://xxxx:xxx/nifi-api -user some-nifi-user -password XXXXXX -conf config.json -m updateConfig

codecov[bot] commented 6 years ago

Codecov Report

Merging #50 into master will increase coverage by 0.07%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
+ Coverage   60.88%   60.95%   +0.07%     
==========================================
  Files          19       19              
  Lines        1084     1086       +2     
  Branches      195      195              
==========================================
+ Hits          660      662       +2     
  Misses        349      349              
  Partials       75       75
Impacted Files Coverage Δ
...va/com/github/hermannpencole/nifi/config/Main.java 85.57% <100%> (+0.28%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 865224d...7ff1bb1. Read the comment docs.