golint and minor simplification

hermanschaaf / regex-crossword-solver

A regex crossword solver written in Go, for puzzles like the ones on regexcrossword.com

http://herman.asia/solving-regex-crosswords-using-go

Other

27 stars 4 forks source link

golint and minor simplification #1

Closed peterbourgon closed 9 years ago

peterbourgon commented 9 years ago

Nice package. Just saw this and had a tic :)

peterbourgon commented 9 years ago

By the way, tests fail on go1.3.3 darwin/amd64:

2014/12/14 15:29:38 error parsing regexp: invalid escape sequence: `\1`
--- FAIL: TestSolve (1.62 seconds)
    solve_test.go:139: "Beginner Naughty" case error: error parsing regexp: invalid escape sequence: `\1`
    solve_test.go:139: "Intermediate: Earth" case error: error parsing regexp: invalid escape sequence: `\1`
    solve_test.go:139: "Intermediate: Technology" case error: error parsing regexp: invalid escape sequence: `\1`
FAIL

hermanschaaf commented 9 years ago

Haha, I completely understand, thanks! Yeah, those tests fail because they try to use backreferences, and they are not supported yet. There are some comments on those cases explaining why they fail, but perhaps I should comment the tests out entirely for now.