Review L1 transaction parameters - Githubissues

hermeznetwork / circuits

Implements hermez network zk-Snarks circuits

GNU Affero General Public License v3.0

55 stars 21 forks source link

Review L1 transaction parameters #8

Closed krlosMata closed 3 years ago

krlosMata commented 3 years ago

L1 transaction parameters has been modified and some assumptions are not longer valid on some parameters in this table

Therefore:

full review of all transactions and parameters has to be done in order to check all circuit constraints.
new test with the new assumptions needs to be added

krlosMata commented 3 years ago

According to Hermez contract documentation:

fromIdx	toIdx	loadAmountF	amountF	tokenID(SC)	babyPubKey	l1-user-TX
0	0	0	0(SC)	X	!=0(SC)	createAccount
0	0	!=0	0(SC)	X	!=0(SC)	createAccountDeposit
0	1	X	X	X	!=0(SC)	createAccountDepositAndExit
0	255+	X	X	X	!=0(SC)	createAccountDepositAndTransfer
255+	0	X	0(SC)	X	0(SC)	Deposit
255+	1	0	X	X	0(SC)	Exit
255+	1	!=0	X	X	0(SC)	DepositAndExit
255+	255+	0	X	X	0(SC)	Transfer
255+	255+	!=0	X	X	0(SC)	DepositAndTransfer

As can be seen in the table the type of transaction is determined basically by the fromIdx and toIdx
The 'X' means that can be any valid value and does not change the transaction type
Other parameters must be consistent, for example, if toIdx is 0, amountF must be 0, because there is no L2 transfer

NOTE:

createAccountDepositAndExit & DepositAndExit will not be valid transactions since the smart contract will not allow them