Atomic group with invalid tx - Githubissues

hermeznetwork / hermez-node

Hermez node Go implementation

GNU Affero General Public License v3.0

61 stars 33 forks source link

Atomic group with invalid tx #1040

Closed laisolizq closed 3 years ago

laisolizq commented 3 years ago

Summary of Bug

The transaction info, error_code and error_type in txPool in an invalid atomic group is incorrect.

Expected Behavior

if in an atomic group of 2 transactions there is an incorrect transaction, they should have the following information: Correct tx:

info: BatchNum X. unselectable atomic group Y, tx Z failed due to: W
error_code: 18,
error_type: ErrInvalidAtomicGroup Incorrect tx:
info: BatchNum X. W
error_code: 12,
error_type: ErrNoCurrentNonce

In this case the information is: Correct tx:

info: BatchNum: X.
error_code: 0,
error_type: '' Incorrect tx:
info: BatchNum X. unselectable atomic group Y, tx Z failed due to: W
error_code: 12,
error_type: ErrNoCurrentNonce

Steps to Reproduce

Send atomic group with 2 txs:

one tx correct
one tx incorrect: with nonce > actualNonce (for example)