search

hermeznetwork / hermez-node

Hermez node Go implementation
GNU Affero General Public License v3.0
58 stars 33 forks source link

TODO: Improve Integration tests #1089

Open tclemos opened 3 years ago

tclemos commented 3 years ago

Rationale

double-check proof created before forging the batch https://github.com/hermeznetwork/hermez-node/blob/3fc5b4c531394e9d6a9975e2fa798bbd5029e6a4/test/ethclient.go#L967

control the transactions and allow tx to be controlled after the batch is forged https://github.com/hermeznetwork/hermez-node/blob/3fc5b4c531394e9d6a9975e2fa798bbd5029e6a4/test/ethclient.go#L975-L978

Also look for many of these errTODO and common.ErrTODO like this https://github.com/hermeznetwork/hermez-node/blob/3fc5b4c531394e9d6a9975e2fa798bbd5029e6a4/test/ethclient.go#L640 https://github.com/hermeznetwork/hermez-node/blob/3fc5b4c531394e9d6a9975e2fa798bbd5029e6a4/test/ethclient.go#L739 https://github.com/hermeznetwork/hermez-node/blob/3fc5b4c531394e9d6a9975e2fa798bbd5029e6a4/test/ethclient.go#L777